Skip to content

chore!: Change graceful shutdown username to graceful-shutdown-user #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2024
Merged

chore!: Change graceful shutdown username to graceful-shutdown-user #573

merged 6 commits into from
Apr 23, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 19, 2024 •
edited
Loading

Description

Part of #574

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Changelog updated

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer self-assigned this Apr 19, 2024
@sbernauer sbernauer mentioned this pull request Apr 19, 2024
Closed
@sbernauer sbernauer changed the title docs: Improve docs on graceful shutdown and OPA chore!: Change graceful shutdown username to graceful-shutdown-user Apr 22, 2024
sbernauer added a commit that referenced this pull request Apr 22, 2024
@sbernauer
Rename graceful shutdown user to graceful-shutdown-user (as per #573)
56b7901
siegfriedweber
siegfriedweber requested changes Apr 22, 2024
View reviewed changes
Techassi
Techassi reviewed Apr 22, 2024
View reviewed changes
siegfriedweber
siegfriedweber approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit eee35fe Apr 23, 2024
@sbernauer sbernauer deleted the docs/opa-graceful-shutdown branch April 23, 2024 13:14
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
@siegfriedweber @sbernauer
Grant the privileges required for graceful shutdowns to the admin use…
0a1545f 
…r in the OPA rego rules (#575)

* Grant all privileges to the admin user in the OPA rego rules

* Move the rule external_policies to policies.rego

* Grant only the permission required for graceful shutdowns to admin by default

* Rename graceful shutdown user to graceful-shutdown-user (as per #573)

* Update Rego rule tests

---------

Co-authored-by: Sebastian Bernauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer @Techassi @siegfriedweber